user, push, pull event extensions #944
Conversation
|
@seregamorph |
| * @return GitHub username | ||
| */ | ||
| public String getUsername() { | ||
| return username; |
There was a problem hiding this comment.
I don't see this field in the git user information (https://docs.github.com/en/rest/reference/git#get-a-commit). Where are you finding this?
There was a problem hiding this comment.
Hm, I see it here:
but it isn't in the current GitHub docs. Might be only present in older versions of GitHub Server?There was a problem hiding this comment.
I have it in GitHub (global; not enterprise) standard webhook notification on push event
There was a problem hiding this comment.
@seregamorph
Interesting. Is it possible it is only present on events?
This doesn't include it: https://api.github.com/repos/octocat/Hello-World/git/commits/7fd1a60b01f91b314f59955a4e4d4e80d8edf11d
I'd be okay with adding this if the javadoc clearly states that is only seen on events and we add @Preview @Deprecated annotations to it. I would also ask that you contact GitHub support and ask them to clarify the documentation.
There was a problem hiding this comment.
Done. Marked as
@Preview
@Deprecated
@CheckForNull
and added javadoc
There was a problem hiding this comment.
The topic is published https://github.1git.demunity/t/push-event-structure-author-committer-id-for-commits/134109 but there is still no answers.
| * @return compare | ||
| */ | ||
| public String getCompare() { | ||
| return compare; |
There was a problem hiding this comment.
https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#push
Has compare in the example but not in the documented fields. Not sure which is in error. 😢
There was a problem hiding this comment.
You can check the Webhook payload example on the link that you gave, the field is here (but not listed in description, right)
seregamorph
force-pushed
the
feature/push-pulls-extensions
branch
from
0d92f76
to
b7d03f7
Compare
|
|
|
@seregamorph |
Yes. I raised a question in https://github.1git.demunity, but it still waits for moderation. So let's wait a bit. |
|
GitHub community topic is still under review and is not published (already 3 days). Anything else I can do here now? |
Description
pull_request(GHEventPayload.PullRequest) new fieldlabelof type GHLabel (may present when"action":"labeled"); example json with test providedpush(GHEventPayload.Push) new fieldcompareGitUsernew fieldusername(e.g. push.commits[*].author.username)Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: