-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user, push, pull event extensions #944
user, push, pull event extensions #944
Conversation
@seregamorph |
* @return GitHub username | ||
*/ | ||
public String getUsername() { | ||
return username; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this field in the git user information (https://docs.github.com/en/rest/reference/git#get-a-commit). Where are you finding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I see it here:
"username": "baxterthehacker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have it in GitHub (global; not enterprise) standard webhook notification on push
event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seregamorph
Interesting. Is it possible it is only present on events?
This doesn't include it: https://api.github.com/repos/octocat/Hello-World/git/commits/7fd1a60b01f91b314f59955a4e4d4e80d8edf11d
I'd be okay with adding this if the javadoc clearly states that is only seen on events and we add @Preview @Deprecated
annotations to it. I would also ask that you contact GitHub support and ask them to clarify the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Marked as
@Preview
@Deprecated
@CheckForNull
and added javadoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The topic is published https://github.1git.demunity/t/push-event-structure-author-committer-id-for-commits/134109 but there is still no answers.
* @return compare | ||
*/ | ||
public String getCompare() { | ||
return compare; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#push
Has compare
in the example but not in the documented fields. Not sure which is in error. 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check the Webhook payload example
on the link that you gave, the field is here (but not listed in description, right)
0d92f76
to
b7d03f7
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few questions left to resolve. Thanks for working on this.
@seregamorph |
Yes. I raised a question in https://github.1git.demunity, but it still waits for moderation. So let's wait a bit. |
GitHub community topic is still under review and is not published (already 3 days). Anything else I can do here now? |
Description
pull_request
(GHEventPayload.PullRequest
) new fieldlabel
of type GHLabel (may present when"action":"labeled"
); example json with test providedpush
(GHEventPayload.Push
) new fieldcompare
GitUser
new fieldusername
(e.g. push.commits[*].author.username)Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master
. Create your PR from that branch.mvn clean compile
locally. This may reformat your code, commit those changes.mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.When creating a PR: