pull_request action "edited": changes #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seregamorph
commented
Nov 18, 2020
| @SuppressFBWarnings("UWF_UNWRITTEN_FIELD") | ||
| public class GHPullRequestChanges { | ||
|
|
||
| private GHCommitPointer base; |
There was a problem hiding this comment.
base changed - covered with UT
title changed - covered with UT
body changed - cover on demand
seregamorph
commented
Nov 18, 2020
| assertThat(event.getPullRequest().getTitle(), is("REST-276 - easy-random")); | ||
| assertThat(event.getChanges().getBase().getRef().getFrom(), is("develop")); | ||
| assertThat(event.getChanges().getBase().getSha().getFrom(), is("4b0f3b9fd582b071652ccfccd10bfc8c143cff96")); | ||
| assertThat(event.getPullRequest().getBody(), startsWith("**JIRA Ticket URL:**")); |
There was a problem hiding this comment.
body not changed - hence "changes" does not contain it
bitwiseman
reviewed
Nov 18, 2020
bitwiseman
reviewed
Nov 18, 2020
| assertThat(event.getChanges().getBase(), nullValue()); | ||
| assertThat(event.getPullRequest().getBody(), startsWith("**JIRA Ticket URL:**")); | ||
| assertThat(event.getChanges().getBody(), nullValue()); | ||
| assertThat(event.getChanges(). getChanges(), nullValue()); |
There was a problem hiding this comment.
Suggested change
| assertThat(event.getChanges(). getChanges(), nullValue()); |
bitwiseman
reviewed
Nov 18, 2020
|
@bitwiseman not sure what changes did you expect. My logic was: for three fields: |
bitwiseman
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Webhook with
X-GitHub-Event: pull_requestand"action": "edited"has a field"changes"that is not present inGHEventPayload.PullRequest. I've found three triggers that leads to "edited" action:(full payload - in test data)
So,
"changes"fields contain old value that was changed, whilepull_requestobject has latest values (see UT json payloads). Any other changes of a PR in GitHub UI leads to other types of notifications (e.g.actionisassignedorready_for_revieworlabeled).