Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add afterHours parameter to IEX intraday requests #537

Open
GenusGeoff opened this issue Dec 3, 2020 · 4 comments
Open

[Enhancement] Add afterHours parameter to IEX intraday requests #537

GenusGeoff opened this issue Dec 3, 2020 · 4 comments

Comments

@GenusGeoff
Copy link
Contributor

  • Tiingo Python version: 0.13
  • Python version: 3.8.5
  • Operating System: Ubuntu 18.04 LTS/Linux

Description

I suggest that we add the afterHours=<TRUE/FALSE> flag for IEX intraday quotes (REST endpoint). I may code this myself as I'm spending a bit more time with this project. But, I wanted to make the official request.

What I Did

N/A

?afterHours=True [or False, defaults to False]

FILES AFFECTED: api.py

@hydrosquall
Copy link
Owner

Hi @GenusGeoff , thanks for filing this! I think this would be a welcome addition.

There was a contribution that someone started last year, but didn't end up finishing. I left some notes on the PR It points to the area of code that you might end up modifying, if you'd like to use it as a reference. Let me know if you have any questions about how to make a modification to the library - I have documentation here for how to get a local environment set up.

#332

@GenusGeoff
Copy link
Contributor Author

I will find some time to work on this some more. I appreciate the feedback.

@GenusGeoff
Copy link
Contributor Author

Please see #527

@GenusGeoff
Copy link
Contributor Author

Please see Bug Fix #600 before attempting to implement this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants