Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for After Hours data #332

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ZeroCool2u
Copy link

@ZeroCool2u ZeroCool2u commented Sep 12, 2019

@hydrosquall

Add support for afterHours parameter via IEX intraday query.

See 2.5.3 Historical Intraday Prices Endpoint: https://api.tiingo.com/documentation/iex

🎉 Hello there 🎉! Thanks for taking the time to contribute to Tiingo-Python!

Summary of Changes

  • What is the motivation / context for this change?
    Add support for afterHours parameter via IEX intraday query.
  • Is this a bugfix or a feature?
    Feature
  • What does this change / fix? (Link to Github Issue page if applicable)
    There is no open issue for this feature.

Checklist

  • Code follows the style guidelines of this project
  • Added tests for new functionality
  • Update HISTORY.rst with an entry summarizing your change
  • Tag a project maintainer

Add support for afterHours parameter via IEX intraday query. 

See 2.5.3 Historical Intraday Prices Endpoint: https://api.tiingo.com/documentation/iex
@hydrosquall
Copy link
Owner

hydrosquall commented Sep 14, 2019

Hi @ZeroCool2u , thanks for the submission! It looks like the forceFill parameter was added too since this library first came out. I only just noticed this from checking the docs. If you'd like, feel free to include that in the PR, otherwise I'll open one separately after yours goes through.

In addition to modifying get_dataframe, I think it might make sense to provide the default you added to the the get_ticker_price method as well.

Let me know if you have any questions about how to update the code or the tests. It looks like we'll need to regenerate some of the YAML fixtures to get the Travis build to pass again. We have some documentation about how to record new fixtures + remove your API key from the result in our documentation page here.

@GenusGeoff
Copy link
Contributor

Okay, I found the old request that you referred to here.

@bossdown123
Copy link

this needs to be merged asap

@hydrosquall
Copy link
Owner

hydrosquall commented Aug 15, 2023 via email

@GenusGeoff
Copy link
Contributor

GenusGeoff commented Aug 15, 2023

@hydrosquall Thank you for your kind words here. Thank you for making this a great community to be a part of, as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants