Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): worked-around deprecation of poll_accept method in tokio #1890

Merged
merged 2 commits into from
Aug 14, 2019
Merged

fix(server): worked-around deprecation of poll_accept method in tokio #1890

merged 2 commits into from
Aug 14, 2019

Conversation

yotamofek
Copy link
Contributor

@yotamofek yotamofek commented Aug 6, 2019

This fixes building with the tokio master branch head.
Refactoring will be required to actually use the new accept async fn.
Build was broken by: tokio-rs/tokio@6d8cc4e

This fixes building with the tokio master branch head.
Refactoring will be required to actually use the new `accept` async fn.
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! (And sorry for the delay)

@seanmonstar seanmonstar merged commit 9d5299b into hyperium:master Aug 14, 2019
@yotamofek
Copy link
Contributor Author

No worries,
glad I could help - It's exciting because it's my first contribution to the Rust ecosystem :)
Do you think there should be any performance implications to this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants