fix(client): send content-length even with no body #3630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most request methods define a payload. If hyper detects that no body has been included, it will now include a `content-length: 0` header automatically. It will not do this for methods that don't have defined payloads (GET, HEAD, and CONNECT).
seanmonstar
force-pushed
the
client-http1-auto-content-length
branch
from
5d3993d
to
4be4be9
Compare
dswij
approved these changes
Apr 14, 2024
ckcr4lyf
reviewed
Apr 16, 2024
| @@ -1468,6 +1474,11 @@ impl Client { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "client")] | |||
| fn is_method_assumed_empty(method: &Method) -> bool { | |||
| matches!(method, &Method::GET | &Method::HEAD | &Method::CONNECT) | |||
There was a problem hiding this comment.
I'd think OPTIONS and DELETE should be included here? Probably also TRACE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most request methods define a payload. If hyper detects that no body has been included, it will now include a
content-length: 0header automatically.It will not do this for methods that don't have defined payloads (GET, HEAD, and CONNECT).