Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http1): reject final chunked if missing 0 #3699

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(http1): reject final chunked if missing 0 #3699

merged 1 commit into from
Jul 9, 2024

Commits on Jul 9, 2024

  1. fix(http1): reject final chunked if missing 0 

    If a chunked body had valid chunks, but ended without a `0` in the final
chunk (so, just `\r\n\r\n`), it would be parsed as a valid end. Now it
will be rejected as the final chunk MUST be `0\r\n\r\n`.

This was partially done before, but only if there were no chunks before
the final. This fixes both paths.
    @seanmonstar
    seanmonstar committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ac1a9de View commit details
    Browse the repository at this point in the history