Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make numexpr an optional dependency to allow installation in pyodide #80

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Aug 25, 2024

Progress of the PR

  • make numexpr an optional dependency,
  • update installation instruction accordingly,
  • fix heading in user guide
  • [n/a] docstring updated (if appropriate),
  • update user guide (if appropriate),
  • update tests,
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:exspy build of this PR (link in github checks)
  • ready for review.

@ericpre ericpre changed the title Make numexpr an optional dependencies to allow installation in pyodide. Make numexpr an optional dependencies to allow installation in pyodide Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.63%. Comparing base (75ca046) to head (7775257).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
exspy/_utils.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage   88.62%   88.63%           
=======================================
  Files          76       77    +1     
  Lines        7411     7425   +14     
  Branches     1192     1195    +3     
=======================================
+ Hits         6568     6581   +13     
  Misses        574      574           
- Partials      269      270    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre changed the title Make numexpr an optional dependencies to allow installation in pyodide Make numexpr an optional dependency to allow installation in pyodide Aug 25, 2024
@ericpre ericpre added this to the v0.3 milestone Aug 25, 2024
@ericpre ericpre added documentation Improvements or additions to documentation enhancement New feature or request needs review dependencies Pull requests that update a dependency file labels Aug 25, 2024
@ericpre
Copy link
Member Author

ericpre commented Aug 25, 2024

@francisco-dlp, this should allow installation in pyodide.

@jlaehne jlaehne merged commit ee31d0a into hyperspy:main Sep 11, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants