Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NMF option to decomposition menu and toolbar #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jat255
Copy link
Member

@jat255 jat255 commented Aug 15, 2018

This PR adds an "NMF" button to the toolbar and decomposition menu that sits alongside the PCA and BSS buttons. I was a little unsure of how to implement it in some places, so I'd be happy to hear any reviews. I mostly copied the BSS code, since it has to do the same thing (display scree to user, get a click, and then perform the decomposition). It seems to work in my testing, but comments are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant