-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add delmic load function #139
base: main
Are you sure you want to change the base?
Conversation
Tests are failing, because |
Hi Jonas,
Yes I'll do it later today, sorry about that.
Best,
Noémie
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 87.67% 87.70% +0.02%
==========================================
Files 83 85 +2
Lines 11149 11173 +24
Branches 2414 2414
==========================================
+ Hits 9775 9799 +24
Misses 860 860
Partials 514 514 ☔ View full report in Codecov by Sentry. |
Thanks for putting this forward @noemiebonnet As far as I understand, it only reads spectral images and not other types of Delmic-HDF5 files (e.g. single spectra, intensity maps, angle-resolved data) so far? Note that we changed the placement and handling of the test data files in #123 Concerning the metadata, it would be great if the full metadata tree from the hdf5 file could be placed under For the fields mentioned in https://docs.lumispy.org/en/latest/user_guide/metadata_structure.html it would be great if they can be mapped to the |
rsciio/delmic/specifications.yaml
Outdated
@@ -0,0 +1,8 @@ | |||
name: delmic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: delmic | |
name: Delmic | |
}, | ||
] | ||
|
||
metadata = {"signal": {"signal_type": "", "quantity": "Intensity (counts)"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If LumiSpy is installed, signal_type
should be set to CL
to provide the CL specific functions.
|
||
metadata = {"signal": {"signal_type": "", "quantity": "Intensity (counts)"}} | ||
|
||
original_metadata = dict(DimensionScaleX="182", DimensionScaleY="132") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess these fixed values are just from testing so far?
I added a progress tracker to the initial comment. It helps show others how far this PR is, feel free to amend the list by editing the comment. |
e793735
to
c9d9bcc
Compare
ceea371
to
3f5c79d
Compare
3f5c79d
to
1debc90
Compare
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
Description of the change
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)