A couple of small fixes that I noticed #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanh
commented
Jul 6, 2022
Comment on lines
-26
to
-31
| @property | ||
| @lru_cache | ||
| def abspath_hash(self): | ||
| hash_ = hashlib.sha512() | ||
| hash_.update(self.abspath.encode("utf8")) | ||
| return hash_.hexdigest() |
There was a problem hiding this comment.
It was using a hash of the absolute path to the requirements file as the cache key. There's no need: just use the absolute path directly as the cache key.
seanh
commented
Jul 6, 2022
| @@ -75,7 +68,6 @@ def pip_sync_maybe(src_files, args): | |||
|
|
|||
| def entry_point(): # pragma: nocover | |||
| parser = ArgumentParser() | |||
| parser.add_argument("-n", "--dry-run", action="store_true") | |||
seanh
commented
Jul 6, 2022
Comment on lines
-16
to
-19
| @property | ||
| @lru_cache | ||
| def path(self): | ||
| return self._path |
There was a problem hiding this comment.
The path property was unnecessary, can just use a path attribute (as long as no one ever mutates path as that would invalidate the cached abspath and contents_hash properties, but this is really a very small script)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.