Allow setting brightness values via config #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @davidbanham, would it be possible to rebase this against the 3.1.0 branch and update the config-schema for this? Looking to pull this into the 3.1.0 release i am going to push out in the next few weeks (currently in beta). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes in minBrightness, maxBrightness and brightnessStep from the config file.
By using the standard convertBrightnessFromHomeKitToTuya function it also respects the value of scaleBrightness if it is set.
This allows the same accessory code to be used for both the Arlec Grid Connect Ceiling Fan and the Deta Grid Connect Smart Fan Speed Controller.