Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchResultBackgroundRenderer doesn't highlight short search results correctly for proportional fonts #316

Closed
simon-vaz-innoveo opened this issue Oct 29, 2021 · 2 comments · Fixed by #329

Comments

@simon-vaz-innoveo
Copy link

Using the standard SearchPanel, if we are using a proportional font (like Segoe UI) instead of a monospaced one, we get the highlight rectangles like this:
image
The SearchResultBackgroundRenderer class hardcodes the CornerRadius of the geoBuilder to "3" that is used for the highlighting. If we could make this border radius configurable, setting it to 0 would give us proper highlighting for proportionate fonts also:
image

@siegfriedpammer
Copy link
Member

@simon-vaz-innoveo would you be able to try the proposed changes in #329 and provide feedback? Thanks!

@simon-vaz-innoveo
Copy link
Author

@siegfriedpammer , it works like a charm. Thanks for the fix. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants