Add "private protected" support #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for you pull request, while the changes look quite good, we haven't yet decided how to deal with testing/implementing C# 7+ features, we now have to pull forward an internal architecture discussion. Please note this might take a while. Note: before accepting your PR we would ask you to add some unit tests, but as mentioned above we haven't yet decided on how we want to handle testing multiple versions of Roslyn / language versions. So, currently adding unit tests would only break the build. We will update you as soon as we've implemented proper support for testing > C# 7.0 features. |
…stacktrace to be printed instead of a user friendly "File doesn't exist" message
Version -> 1.7 Re-enable Enterprise sku (locally found, marketplace didn't)
…That also hid a throw on assembly resolution.
|
Note: I will add some unit tests and then merge your PR. |
|
Thank you for your pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes "private protected" display for C# 7.2.