Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# 9 Records #2251

Merged
merged 16 commits into from
Jan 1, 2021
Merged

C# 9 Records #2251

merged 16 commits into from
Jan 1, 2021

Conversation

dgrunwald
Copy link
Member

@dgrunwald dgrunwald commented Dec 28, 2020 •
edited
Loading

See #2217.

The decompiler now omits methods inside a record if the body looks like the default implementation that would be emitted by the C# compiler.

TODO:

  • Tests
  • Equals() in derived records
  • Primary constructor syntax
  • with-expressions

@dgrunwald
Use "record" instead of "class" for C# 9 record class types.
f869756
@dgrunwald
Omit members from record definitions if they are always compiler-gene…
9e589fa 
…rated.
@dgrunwald
Records: Omit "IEquatable" in base class list
da4539b
@dgrunwald
Omit EqualityContract if it's automatically generated.
90ce77f
@dgrunwald
Records: detect when ToString() is compiler-generated
0babcc5
@dgrunwald
Records: detect when PrintMembers() is compiler-generated
500317a 
Only for the simple case: record having only (auto-)properties but no fields and no inheritance.
@dgrunwald
Records: detect when PrintMembers() is compiler-generated in derived …
4fefd5f 
…records
@dgrunwald
Records: hide generated Equals() method
648e7f9
@dgrunwald
Records: detect whether GetHashCode is compiler-generated
c95f75d
@dgrunwald
Hide [NullableContext] on accessors
4050d39
@dgrunwald
Records: detect copy constructor
e02c478
@dgrunwald dgrunwald added this to the v7.0-p2 milestone Dec 28, 2020
@dgrunwald dgrunwald merged commit 174c14a into master Jan 1, 2021
@dgrunwald dgrunwald deleted the records branch January 1, 2021 23:26
ElektroKill added a commit to dnSpyEx/ILSpy that referenced this pull request Aug 10, 2021
@ElektroKill
Merge pull request icsharpcode#2251 from icsharpcode/records
d50f637 
C# 9 Records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedpammer siegfriedpammer siegfriedpammer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v7.0-p2
Development

Successfully merging this pull request may close these issues.
2 participants
@dgrunwald @siegfriedpammer