IMPB-1513 non-US state abbreviations like those from a650 VNMLS are not detected by the Omnibar search JS, causing incorrect search results #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…z ID is used for locations in states like NAY and JAL in VNMLS this avoids having to rely on a hardcoded list of state abbreviations
antonioortegajr
suggested changes
Aug 25, 2024
| // Add state abbreviations to the set for later reference | ||
| array.forEach((item) => { | ||
| if (item.stateAbrv) { | ||
| console.log(item.stateAbrv); |
There was a problem hiding this comment.
I don't think this console log is needed. Everything else looks like it works fine! Good stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Requests
🐛 Are you fixing a bug? Y
The plugin uses a hardcoded list of states to detect when parsing the Omnibar input and trying to determine what CCZ id should be used when handling an input like “City, StateAbreviation”.
Some example state abbreviations from VNMLS include JAL and NAY. These are not included in the current hardcoded list, so they are not detected by the whatState function. This results in an address search being performed even if a valid state abbreviation is entered, which usually results in 0 results.
Template
Description of the Change
A set is used to keep track of all state abbreviations found in the locationlist.js file for later reference when the user input is parsed to determine what type of search to make.
Verification Process
Release Notes
Fix: Handle more non-US state abbreviations when performing an Omnibar search.
Review
Pull Requests must have the sign-off of two other developers and at least one of these must be an IDX Broker team member.