-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uf/#57-fixLineTypeMismatch #79
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 62.21% 62.15% -0.07%
==========================================
Files 69 69
Lines 1985 1971 -14
Branches 14 14
==========================================
- Hits 1235 1225 -10
+ Misses 750 746 -4
Continue to review full report at Codecov.
|
…e than one rated voltage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, I would wish for an integration test, that checks, what you have fixed. So having two source lines with the same type, but different voltage level and then checking if the right ones are selected.
- Basic functionality to convert SimBench data sets to [PowerSystemDataModel](https://github.com/ie3-institute/powersystemdatamodel) | ||
|
||
### Changed | ||
- Line type can be mapped to more than one vRated voltage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CHANGELOG should be cumulative. That means, that you please keep, what is written under [1.0.0]
and add your Changed
part beneath Unreleased
inputData/config/EHV.conf
Outdated
@@ -0,0 +1,26 @@ | |||
io { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the config. Those files should be kept locally.
nodes: Map[Node, NodeInput] | ||
): Vector[LineInput] = | ||
inputs.par.flatMap { | ||
case acLine: Line.ACLine => | ||
val (nodeA, nodeB) = | ||
NodeConverter.getNodes(acLine.nodeA, acLine.nodeB, nodes) | ||
val lineType = types.getOrElse( | ||
acLine.lineType, | ||
(acLine.lineType, Quantities.getQuantity(acLine.nodeA.vmR, KILOVOLT)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we use a composite key to access a map. However, the second part (the voltage) is set up from Doubles. Thus, it could be error prone. Maybe you may add a warning comment, that this only works, if you don't do any calculations with the voltage, that you provide here.
@@ -322,7 +322,7 @@ final case class SimbenchReader( | |||
read(clazz, fields) | |||
} | |||
), | |||
Duration("10 s") | |||
Duration("100 s") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't commit this, as it was just an adaption to make it run on your PC.
…uration" in SimbenchReader.
…warning comment in LineConverter.
Resolves #57