Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR comment if the action contributing guidelines have been met #10

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

danielle-casella-adams
Copy link
Member

Summary of PR changes

This adds a PR comment if there are changes to the action and the contributing guidelines have been met. This includes recompiling the action and updating the version in the readme. Previously you only got a comment on the PR and the workflow summary if you needed to make changes. Once those changes were addressed there wasn't an indication that you addressed the issue other than the status check being updated but it was a little confusing with the outstanding comment.

This was tested in an action that has a build step and one that does not:

@danielle-casella-adams danielle-casella-adams requested a review from a team as a code owner April 3, 2024 18:46
@cbchadb35 cbchadb35 merged commit 342a925 into main Apr 3, 2024
4 checks passed
@cbchadb35 cbchadb35 deleted the satisfied-conditions branch April 3, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants