Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-253 - Added trust certificate to run-test.ps1 #26

Merged
merged 24 commits into from
Jun 9, 2023
Merged

SRE-253 - Added trust certificate to run-test.ps1 #26

merged 24 commits into from
Jun 9, 2023

Conversation

jsclifford
Copy link
Contributor

@jsclifford jsclifford commented Jun 8, 2023 •
edited
Loading

  • Adding trust certificates to the run-test.ps1 where it was missing
  • Fixed rebindSql and unbindSql paramaters with powershell interperation.

@jsclifford jsclifford requested a review from a team as a code owner June 8, 2023 14:51
bbelnap
bbelnap reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@bbelnap bbelnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few ideas about resolving the quoting issue

src/tsqlt/run-tests.ps1 Outdated Show resolved Hide resolved
src/tsqlt/run-tests.ps1 Outdated Show resolved Hide resolved
@jsclifford jsclifford marked this pull request as draft June 8, 2023 21:20
@jsclifford jsclifford marked this pull request as ready for review June 9, 2023 21:21
JosephDSchwartz
JosephDSchwartz approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@JosephDSchwartz JosephDSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jsclifford jsclifford merged commit e2b563b into main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbelnap bbelnap bbelnap left review comments

@JosephDSchwartz JosephDSchwartz JosephDSchwartz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsclifford @bbelnap @JosephDSchwartz