Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes around filesystem locations #29

Closed
wants to merge 1 commit into from

Conversation

stevetaggart
Copy link

Removing these quotes allowed my flyway migrations which contained two different folders to run on a linux runner.

Before this change flyway produced an error saying the migration locations weren't found and the migrations didn't run successfully.

Summary of PR changes

PR Requirements

  • For major, minor, or breaking changes, at least one of the commit messages contains the appropriate +semver: keywords.
    • See the Incrementing the Version section of the repository's README.md for more details.
  • The action code does not contain sensitive information.

NOTE: If the repo's workflow could not automatically update the README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.

@stevetaggart stevetaggart requested a review from a team as a code owner July 19, 2023 22:51
@JosephDSchwartz
Copy link
Contributor

@stevetaggart do you have links to the failed/successful runs before and after this change? And did we double check the action still works on windows runners as well as linux?

Removing these quotes allowed my flyway migrations which contained two different folders to run on a linux runner. 

Before this change flyway produced an error saying the migration locations weren't found and the migrations didn't run successfully.
@danielle-casella-adams
Copy link
Member

Closing after checking with @stevetaggart. Please feel free to open this back up if you come across the issue again in the future.

@migonza migonza mentioned this pull request Jan 16, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants