Added compression and f32 support for TIFF encoding/decoding. #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
reviewed
Jun 2, 2024
There was a problem hiding this comment.
This is a pretty big image to check into the repository. Could you crop it / make a smaller one?
There was a problem hiding this comment.
Do you want me to break it into F32 stuff and compression?
|
CI seems to be failing because this exposes the tiff crate's |
|
I somehow missed this, just pushed changes that hide tiff crate's |
|
@fintelia can you please take a look at this? |
|
I've been taking a hiatus from most PR review and issue triage because I got burned out following the 0.25 release. Another reviewer might have a chance to review this at some point |
|
@fintelia I hope you feel better soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.
f32 encoding/decoding support is added without additional byte alignment requirements. Removed 2-byte alignment requirement for u16 encoding/decoding. Added TIFF compression support.