Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for headless/server builds #1

Merged
merged 1 commit into from
May 31, 2021
Merged

Support for headless/server builds #1

merged 1 commit into from
May 31, 2021

Conversation

lihop
Copy link
Contributor

@lihop lihop commented May 31, 2021

Firstly, thank you for making and sharing this awesome plugin. I expect to be using it a lot!

Secondly, would you consider adding support for Godot headless and server builds?

This is especially useful for the running the plugin in headless CI/CD environments such as GitHub actions.

It should be as easy as adding "Server" alongside "X11" and "OSX" as headless/server builds are currently only supported on Linux and macOS.

I tested this change using a basic plugin.gd file with server/headless builds locally on my Linux laptop and on GitHub actions using this Godot headless Docker image (results here) , and everything seems to be working fine.

@imjp94
Copy link
Owner

imjp94 commented May 31, 2021

Thanks, glad that it helps!

My bad, I thought "X11" includes all Linux machine.

Will merge this PR when I get to my desktop.

Thanks for the contribution!

@imjp94 imjp94 merged commit 83cd8f5 into imjp94:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants