-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move .plugged to addons/gd-plug/.plugged #33
base: master
Are you sure you want to change the base?
Conversation
Moving the dir here stops gdscript warnings from triggering on addon code. The Godot team have indicated that they will only support disabling warnings in this directory as it is the only place third party code should be placed.
Thanks for the contribution! However, I will have to wait until godotengine/godot#93889 actually merged into Godot master branch. |
Why does this change depend on godotengine/godot#93889? In the current Godot release you can enable I didn't consider automated migration since I had been deleting the |
Oh, I didn't know Automated migration is necessary for a smooth user experience, otherwise, the old |
581764e
to
80162d3
Compare
These options should apply to the path within the source directory, not the local project's path after copying them to .plugged.
80162d3
to
b45809a
Compare
FYI in case you decide to use this as a starting point when you pick this up. Something seems to have changed in Godot that has caused this PR to break. It isn't moving files from |
Moving the dir here stops gdscript warnings from triggering on addon code. The Godot team have indicated that they will only support disabling warnings in this directory as it is the only place third party code should be placed.
This change addresses #32, following the discussion there and at godotengine/godot#93889