refactor(publicodes-state): reviewed helpers

src/publicodes-state/helpers/getQuestionsOfMosaic.ts

@@ -1,3 +1,5 @@
+import { RuleName } from '@/publicodes-state/types'
+
 type Props = {
   dottedName: RuleName
   everyMosaicChildWhoIsReallyInMosaic: RuleName[]

src/publicodes-state/helpers/safeEvaluateHelper.ts

@@ -1,7 +1,7 @@
-import { Engine, NGCEvaluatedNode } from '../types'
+import { Engine, NGCEvaluatedNode, RuleName } from '../types'
 
 export const safeEvaluateHelper = (
-  rule: string,
+  rule: RuleName,
   engineUsed: Engine
 ): NGCEvaluatedNode | null => {
   try {

src/publicodes-state/helpers/safeGetSituation.ts

@@ -1,18 +1,18 @@
-import { NodeValue, Situation } from '../types'
+import { RuleName, Situation } from '../types'
 
 export const safeGetSituation = ({
   situation,
   everyRules,
 }: {
   situation: Situation
-  everyRules: string[]
-}): any =>
+  everyRules: RuleName[]
+}): Situation =>
   everyRules
-    .filter((rule: string) => situation[rule] || situation[rule] === 0)
+    .filter((rule: RuleName) => situation[rule] || situation[rule] === 0)
     .reduce(
-      (accumulator: Record<string, NodeValue>, currentValue: string) => ({
-        ...accumulator,
-        [currentValue]: situation[currentValue],
+      (situationAcc: Situation, currentRule: RuleName) => ({
+        ...situationAcc,
+        [currentRule]: situation[currentRule],
       }),
       {}
     )