Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up clang-tidy warnings #209

Closed
IceflowRE opened this issue Jul 30, 2020 · 6 comments · Fixed by #263
Closed

Clean up clang-tidy warnings #209

IceflowRE opened this issue Jul 30, 2020 · 6 comments · Fixed by #263
Assignees
Labels
cat:refactor refactor/clean up/simplifications/etc. diff:beginner beginner skils required diff:first issue good first issue to start contributing prio:high This has high priority.

Comments

@IceflowRE
Copy link
Member

There are a lot of warnings like unused variables, uninitialized variables, etc....

@IceflowRE IceflowRE added diff:beginner beginner skils required prio:high This has high priority. cat:refactor refactor/clean up/simplifications/etc. diff:first issue good first issue to start contributing labels Jul 30, 2020
@IAmNotHanni
Copy link
Member

Right. We should solve them as soon as possible.

@IAmNotHanni IAmNotHanni self-assigned this Jul 30, 2020
@IAmNotHanni
Copy link
Member

I think the best way to address this is to create pull requests sorted by the type of clang-tidy warning.

@IAmNotHanni IAmNotHanni pinned this issue Aug 15, 2020
@IAmNotHanni IAmNotHanni unpinned this issue Aug 16, 2020
@IAmNotHanni
Copy link
Member

I will focus on this after imgui PR is merged.
We need more planing on octree anyways.

@IAmNotHanni
Copy link
Member

The issues which were easy to fix are solved in #250.

@IAmNotHanni
Copy link
Member

IAmNotHanni commented Sep 19, 2020

This leaves us with the following issues:
❌ means not fixed, ➖ means ignored, ✔️ means fixed.

Warning G1510A767: Constructors/Destructors: Issues with rule of 0, 3 or 5

Fixed? File Description
availability_checks.hpp(12,7) class 'AvailabilityChecksManager' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
availability_checks.hpp(12,7) class 'AvailabilityChecksManager' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]
fps_counter.hpp(10,7) class 'FPSCounter' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
fps_counter.hpp(10,7) class 'FPSCounter' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]
frame_graph.hpp(32,8) class 'FrameGraphObject' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
frame_graph.hpp(32,8) class 'FrameGraphObject' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]
frame_graph.hpp(47,7) class 'RenderResource' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [cppcoreguidelines-special-member-functions]
frame_graph.hpp(47,7) class 'RenderResource' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [hicpp-special-member-functions]
frame_graph.hpp(159,7) class 'RenderStage' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [cppcoreguidelines-special-member-functions]
frame_graph.hpp(159,7) class 'RenderStage' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [hicpp-special-member-functions]
frame_graph.hpp(201,7) class 'GraphicsStage' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [cppcoreguidelines-special-member-functions]
frame_graph.hpp(201,7) class 'GraphicsStage' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [hicpp-special-member-functions]
frame_graph.hpp(231,7) class 'PhysicalResource' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [cppcoreguidelines-special-member-functions]
frame_graph.hpp(231,7) class 'PhysicalResource' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [hicpp-special-member-functions]
frame_graph.hpp(283,7) class 'PhysicalBackBuffer' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [cppcoreguidelines-special-member-functions]
frame_graph.hpp(283,7) class 'PhysicalBackBuffer' defines a copy constructor, a copy assignment operator, a move constructor and a move assignment operator but does not define a destructor [hicpp-special-member-functions]
gpu_info.hpp(8,7) class 'VulkanGraphicsCardInfoViewer' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
gpu_info.hpp(8,7) class 'VulkanGraphicsCardInfoViewer' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]
renderer.hpp(39,7) class 'VulkanRenderer' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
renderer.hpp(39,7) class 'VulkanRenderer' defines a non-default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]
settings_decision_maker.hpp(23,7) class 'VulkanSettingsDecisionMaker' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
settings_decision_maker.hpp(23,7) class 'VulkanSettingsDecisionMaker' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]
time_step.hpp(10,7) class 'TimeStep' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
time_step.hpp(10,7) class 'TimeStep' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [hicpp-special-member-functions]

Warning G403A5994: Issues with class access specifiers and member visibility

Fixed? File Description
camera.hpp(23,16) member variable 'm_type' has public visibility [misc-non-private-member-variables-in-classes]
camera.hpp(25,15) member variable 'm_rotation' has public visibility [misc-non-private-member-variables-in-classes]
camera.hpp(26,15) member variable 'm_position' has public visibility [misc-non-private-member-variables-in-classes]
camera.hpp(28,11) member variable 'm_rotation_speed' has public visibility [misc-non-private-member-variables-in-classes]
camera.hpp(29,11) member variable 'm_movement_speed' has public visibility [misc-non-private-member-variables-in-classes]
camera.hpp(31,10) member variable 'm_updated' has public visibility [misc-non-private-member-variables-in-classes]
camera.hpp(36,7) member variable 'm_matrices' has public visibility [misc-non-private-member-variables-in-classes]
camera.hpp(43,7) member variable 'm_keys' has public visibility [misc-non-private-member-variables-in-classes]
frame_graph.hpp(236,18) member variable 'm_allocator' has protected visibility [misc-non-private-member-variables-in-classes]
frame_graph.hpp(237,14) member variable 'm_device' has protected visibility [misc-non-private-member-variables-in-classes]
frame_graph.hpp(238,19) member variable 'm_allocation' has protected visibility [misc-non-private-member-variables-in-classes]
octree_gpu_vertex.hpp(9,15) member variable 'position' has public visibility [misc-non-private-member-variables-in-classes]
octree_gpu_vertex.hpp(10,15) member variable 'color' has public visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(41,51) member variable 'm_gpu_info_manager' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(42,48) member variable 'm_availability_checks_manager' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(43,50) member variable 'm_settings_decision_maker' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(45,50) member variable 'm_shader_stages' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(47,30) member variable 'm_debug_report_callback' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(49,10) member variable 'm_debug_report_callback_initialised' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(51,14) member variable 'm_time_step' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(53,19) member variable 'm_window_width' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(54,19) member variable 'm_window_height' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(56,17) member variable 'm_window_title' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(58,16) member variable 'm_fps_counter' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(61,28) member variable 'm_uniform_buffer_info' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(63,10) member variable 'm_vsync_enabled' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(65,12) member variable 'm_game_camera' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(67,43) member variable 'm_glfw_context' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(68,38) member variable 'm_window' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(69,40) member variable 'm_instance' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(70,38) member variable 'm_device' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(71,45) member variable 'm_surface' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(72,41) member variable 'm_swapchain' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(73,43) member variable 'm_command_pool' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(74,35) member variable 'm_imgui_overlay' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(75,41) member variable 'm_image_available_semaphore' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(76,41) member variable 'm_rendering_finished_semaphore' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(77,33) member variable 'm_frame_graph' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(79,34) member variable 'm_shaders' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(80,38) member variable 'm_textures' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(81,41) member variable 'm_uniform_buffers' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(82,46) member variable 'm_descriptors' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(83,34) member variable 'm_octree_vertices' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(84,32) member variable 'm_octree_indices' has protected visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(97,10) member variable 'm_window_resized' has public visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(100,11) member variable 'm_time_passed' has public visibility [misc-non-private-member-variables-in-classes]
renderer.hpp(103,14) member variable 'm_stopwatch' has public visibility [misc-non-private-member-variables-in-classes]
gpu_memory_buffer.hpp(17,17) member variable 'm_name' has protected visibility [misc-non-private-member-variables-in-classes]
gpu_memory_buffer.hpp(18,19) member variable 'm_device' has protected visibility [misc-non-private-member-variables-in-classes]
gpu_memory_buffer.hpp(19,14) member variable 'm_buffer' has protected visibility [misc-non-private-member-variables-in-classes]
gpu_memory_buffer.hpp(20,18) member variable 'm_buffer_size' has protected visibility [misc-non-private-member-variables-in-classes]
gpu_memory_buffer.hpp(21,19) member variable 'm_allocation' has protected visibility [misc-non-private-member-variables-in-classes]
gpu_memory_buffer.hpp(22,23) member variable 'm_allocation_info' has protected visibility [misc-non-private-member-variables-in-classes]
gpu_memory_buffer.hpp(23,29) member variable 'm_allocation_ci' has protected visibility [misc-non-private-member-variables-in-classes]
instance.hpp(15,16) member variable 'm_instance' has protected visibility [misc-non-private-member-variables-in-classes]
instance.hpp(16,31) member variable 'm_availability_checks' has protected visibility [misc-non-private-member-variables-in-classes]
uniform_buffer.hpp(16,28) member variable 'm_descriptor_buffer_info' has protected visibility [misc-non-private-member-variables-in-classes]
uniform_buffer.hpp(17,21) member variable 'm_descriptor_set' has protected visibility [misc-non-private-member-variables-in-classes]

Warning G403A5994: Issues with class access specifiers and member visibility

Fixed? File Description
imgui.hpp(61,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
command_buffer.hpp(32,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
command_pool.hpp(30,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
device.hpp(60,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
fence.hpp(31,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
framebuffer.hpp(33,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
gpu_memory_buffer.hpp(50,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
gpu_texture.hpp(75,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
graphics_pipeline.hpp(43,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
image.hpp(39,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
mesh_buffer.hpp(94,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
once_command_buffer.hpp(47,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
renderpass.hpp(36,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
resource_descriptor.hpp(41,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
semaphore.hpp(27,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
shader.hpp(44,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
swapchain.hpp(50,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]
uniform_buffer.hpp(31,5) move assignment operator is explicitly defaulted but implicitly deleted, probably because a base class or a non-static data member is not assignable, e.g. because the latter is marked 'const'; definition can either be removed or explicitly deleted [readability-deleted-default]

Warning G6B27326A: Implicitly deleted move assignment operators

Fixed? File Description
swapchain.hpp(50,16) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
shader.hpp(44,13) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
semaphore.hpp(27,16) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
resource_descriptor.hpp(41,25) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
renderpass.hpp(36,17) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
once_command_buffer.hpp(47,24) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
mesh_buffer.hpp(94,17) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
image.hpp(39,12) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
framebuffer.hpp(33,18) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
imgui.hpp(61,19) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
command_buffer.hpp(32,20) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
command_pool.hpp(30,18) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
device.hpp(60,13) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
fence.hpp(31,12) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
gpu_memory_buffer.hpp(50,22) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
gpu_texture.hpp(75,17) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
graphics_pipeline.hpp(43,23) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]
uniform_buffer.hpp(31,20) explicitly defaulted move assignment operator is implicitly deleted [clang-diagnostic-defaulted-function-deleted]

Warning G75DF59F6

Fixed? File Description
uniform_buffer.hpp(28,5) annotate this function with 'override' or (rarely) 'final' [hicpp-use-override]
uniform_buffer.hpp(28,5) annotate this function with 'override' or (rarely) 'final' [modernize-use-override]

Warning GE4E5D495

Fixed? File Description
window_surface.hpp(32,5) do not overload unary operator&, it is dangerous. [google-runtime-operator]

Warning GAB3A7E52

Fixed? File Description
once_command_buffer.hpp(24,19) 'm_queue' declared with a const-qualified typedef type; results in the type being 'VkQueue_T *const' instead of 'const VkQueue_T *' [misc-misplaced-const]

Misc notes

Fixed? File Description
imgui.hpp(26,28) move assignment operator of 'ImGUIOverlay' is implicitly deleted because field 'm_device' is of reference type 'const wrapper::Device &'
command_buffer.hpp(18,28) move assignment operator of 'CommandBuffer' is implicitly deleted because field 'm_device' is of reference type 'const wrapper::Device &'
command_pool.hpp(14,19) move assignment operator of 'CommandPool' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
device.hpp(38,16) move assignment operator of 'Device' is implicitly deleted because field 'm_enable_vulkan_debug_markers' is of const-qualified type 'const bool'
fence.hpp(15,28) move assignment operator of 'Fence' is implicitly deleted because field 'm_device' is of reference type 'const wrapper::Device &'
framebuffer.hpp(15,28) move assignment operator of 'Framebuffer' is implicitly deleted because field 'm_device' is of reference type 'const wrapper::Device &'
gpu_memory_buffer.hpp(18,19) move assignment operator of 'GPUMemoryBuffer' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
gpu_texture.hpp(25,23) move assignment operator of 'GpuTexture' is implicitly deleted because field 'm_copy_command_buffer' has a deleted move assignment operator
once_command_buffer.hpp(46,24) 'operator=' has been explicitly marked deleted here
graphics_pipeline.hpp(15,19) move assignment operator of 'GraphicsPipeline' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
image.hpp(15,28) move assignment operator of 'Image' is implicitly deleted because field 'm_device' is of reference type 'const wrapper::Device &'
mesh_buffer.hpp(30,19) move assignment operator of 'MeshBuffer' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
once_command_buffer.hpp(21,19) move assignment operator of 'OnceCommandBuffer' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
renderpass.hpp(15,19) move assignment operator of 'RenderPass' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
resource_descriptor.hpp(14,23) move assignment operator of 'ResourceDescriptor' is implicitly deleted because field 'm_name' has no move assignment operator
semaphore.hpp(13,19) move assignment operator of 'Semaphore' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
shader.hpp(14,19) move assignment operator of 'Shader' is implicitly deleted because field 'm_device' is of reference type 'const inexor::vulkan_renderer::wrapper::Device &'
swapchain.hpp(16,28) move assignment operator of 'Swapchain' is implicitly deleted because field 'm_device' is of reference type 'const wrapper::Device &'
uniform_buffer.hpp(14,23) move assignment operator of 'UniformBuffer' is implicitly deleted because base class 'inexor::vulkan_renderer::wrapper::GPUMemoryBuffer' has a deleted move assignment operator
gpu_memory_buffer.hpp(49,22) 'operator=' has been explicitly marked deleted here

@IAmNotHanni
Copy link
Member

IAmNotHanni commented Oct 15, 2020

All issues are fixed with the new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:refactor refactor/clean up/simplifications/etc. diff:beginner beginner skils required diff:first issue good first issue to start contributing prio:high This has high priority.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants