-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix most clang-tidy warnings and msvc code analysis warnings #250
Conversation
I will ignore warning |
26d43bc
to
5dc05aa
Compare
Could you use the clang tidy readable strings, not sure where you get the other cryptic thing from. |
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
fdb29ef
to
3d03038
Compare
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
3d03038
to
5f6de02
Compare
This needs some more work. Let me sort it out and convert it from a draft pull request to a real pr later. |
I will open a new pull request instead of git cherrypicking everything in here. I have done a lot of stuff differently in the new pull request and it's much greater now. |
There is no need to review the commits which improve documentation!
See: #248
This will fix the most important issues we have in our code. This brach is based on
hanni/enhance_documentation
. Once we squashed all the documentation commits, we must rebase this again.I will another pull request in which I will fix the advanced issues.
See the full list: #209.