Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix most clang-tidy warnings and msvc code analysis warnings #250

Closed
wants to merge 15 commits into from

Conversation

IAmNotHanni
Copy link
Member

@IAmNotHanni IAmNotHanni commented Sep 18, 2020

There is no need to review the commits which improve documentation!
See: #248

This will fix the most important issues we have in our code. This brach is based on hanni/enhance_documentation. Once we squashed all the documentation commits, we must rebase this again.

I will another pull request in which I will fix the advanced issues.
See the full list: #209.

@IAmNotHanni IAmNotHanni added the cat:refactor refactor/clean up/simplifications/etc. label Sep 18, 2020
@IAmNotHanni IAmNotHanni self-assigned this Sep 18, 2020
@IAmNotHanni
Copy link
Member Author

IAmNotHanni commented Sep 19, 2020

I will ignore warning G403A5994, [misc-non-private-member-variables-in-classes].
It makes sense to have protected members if it's a base class.

@IAmNotHanni IAmNotHanni changed the title Fix clang-tidy warnings Fix clang-tidy warnings and MSVC code analysis warnings Sep 19, 2020
@IAmNotHanni IAmNotHanni changed the title Fix clang-tidy warnings and MSVC code analysis warnings Fix clang-tidy warnings and msvc code analysis warnings Sep 19, 2020
@IAmNotHanni IAmNotHanni force-pushed the hanni/fix_code_warnings branch 2 times, most recently from 26d43bc to 5dc05aa Compare September 19, 2020 10:04
@IAmNotHanni IAmNotHanni marked this pull request as ready for review September 19, 2020 11:50
@IAmNotHanni IAmNotHanni changed the title Fix clang-tidy warnings and msvc code analysis warnings Fix most clang-tidy warnings and msvc code analysis warnings Sep 19, 2020
@IceflowRE
Copy link
Member

Could you use the clang tidy readable strings, not sure where you get the other cryptic thing from.
GC8B399FA -> readability-non-const-parameter

@IAmNotHanni IAmNotHanni marked this pull request as draft October 13, 2020 19:44
@IAmNotHanni
Copy link
Member Author

This needs some more work. Let me sort it out and convert it from a draft pull request to a real pr later.

@IAmNotHanni
Copy link
Member Author

I will open a new pull request instead of git cherrypicking everything in here. I have done a lot of stuff differently in the new pull request and it's much greater now.

@IAmNotHanni IAmNotHanni deleted the hanni/fix_code_warnings branch December 11, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:refactor refactor/clean up/simplifications/etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants