-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance code documentation #248
Conversation
97c63e1
to
96145c5
Compare
@yeetari Already contacted me and pointed out that |
I advise to use |
d8472f7
to
be51ba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove
[in]
in@param
since we agreed not to use call by reference anymore.
I will do the sorting of Doxygen commands in another pull request, together with extending |
Other general things: 1.You wrote somewhere
i just know it from the Python documentation but they advise to write instead:
2.You can drop the 3.Can you replace the 4.I didnt added a suggestion for all the |
Replies
|
|
Ok so in case there are no more requested changes, I will wait for your approval, squash and then merge :) |
Not sure, but as we agreed now to use the Python style we should add a note to it in the styling section in the documentation? |
Thank you for your review! Squash incoming :) |
649f0c9
to
999a4b8
Compare
Signed-off-by: Johannes <[email protected]>
999a4b8
to
413453a
Compare
I documented every file one by one so we can
git cherry-pick
if required.I will squash all commits and requested changes into one before merge.
Closes #81.