Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance code documentation #248

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Conversation

IAmNotHanni
Copy link
Member

@IAmNotHanni IAmNotHanni commented Sep 16, 2020

I documented every file one by one so we can git cherry-pick if required.
I will squash all commits and requested changes into one before merge.
Closes #81.

@IAmNotHanni IAmNotHanni added the cat:documentation documentation label Sep 16, 2020
@IAmNotHanni IAmNotHanni self-assigned this Sep 16, 2020
@IAmNotHanni IAmNotHanni changed the title Hanni/enhance documentation Enhance Doxygen documentation Sep 16, 2020
@IAmNotHanni IAmNotHanni marked this pull request as ready for review September 17, 2020 19:48
@IAmNotHanni
Copy link
Member Author

@yeetari Already contacted me and pointed out that @class is a bit pointless. I will remove it entirely.

@IceflowRE
Copy link
Member

IceflowRE commented Sep 17, 2020

I advise to use [doc] as the category. So [doc] Enhance code documentation

@IAmNotHanni IAmNotHanni force-pushed the hanni/enhance_documentation branch 2 times, most recently from d8472f7 to be51ba1 Compare September 18, 2020 14:25
@IAmNotHanni IAmNotHanni changed the title Enhance Doxygen documentation Enhance code documentation Sep 19, 2020
Copy link
Member Author

@IAmNotHanni IAmNotHanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove [in] in @param since we agreed not to use call by reference anymore.

@IAmNotHanni
Copy link
Member Author

I will do the sorting of Doxygen commands in another pull request, together with extending @brief into @details.

@IceflowRE
Copy link
Member

IceflowRE commented Sep 19, 2020

Other general things:

1.

You wrote somewhere

Tries to find a queue family which supports VK_QUEUE_TRANSFER_BIT.

i just know it from the Python documentation but they advise to write instead:

Try to find a queue family which supports VK_QUEUE_TRANSFER_BIT.

2.

You can drop the @brief as every line with /// is automatically counted as it. (just if you want)

3.

Can you replace the /// with // in the bezier_curve.hpp?
As it is counted as the namesepace description.

4.

I didnt added a suggestion for all the ' issues.

@IAmNotHanni
Copy link
Member Author

IAmNotHanni commented Sep 19, 2020

Other general things:

1.

You wrote somewhere

Tries to find a queue family which supports VK_QUEUE_TRANSFER_BIT.

i just know it from the Python documentation but they advise to write instead:

Try to find a queue family which supports VK_QUEUE_TRANSFER_BIT.

2.

You can drop the @brief as every line with /// is automatically counted as it. (just if you want)

3.

Can you replace the /// with // in the bezier_curve.hpp?
As it is counted as the namesepace description.

4.

I didnt added a suggestion for all the ' issues.

Replies

  1. Done.
  2. I will keep it for now.
  3. Done.
  4. I fixed that everywhere now.

@IceflowRE
Copy link
Member

IceflowRE commented Oct 3, 2020

  1. Right, I thought about that as well. I will postpone this to the next pull request to further improve the comments.
    Please send me links with guidelines for that.

PEP-0257

The docstring is a phrase ending in a period. It prescribes the function or method's effect as a command ("Do this", "Return that"), not as a description; e.g. don't write "Returns the pathname ...".

@IAmNotHanni
Copy link
Member Author

Ok so in case there are no more requested changes, I will wait for your approval, squash and then merge :)

@IceflowRE
Copy link
Member

Not sure, but as we agreed now to use the Python style we should add a note to it in the styling section in the documentation?
documentation/source/development/design/coding-style.rst

@IceflowRE IceflowRE self-requested a review October 12, 2020 12:34
@IAmNotHanni
Copy link
Member Author

Thank you for your review! Squash incoming :)

@IAmNotHanni IAmNotHanni force-pushed the hanni/enhance_documentation branch 2 times, most recently from 649f0c9 to 999a4b8 Compare October 12, 2020 18:12
@IAmNotHanni IAmNotHanni merged commit a43735d into master Oct 12, 2020
@IAmNotHanni IAmNotHanni deleted the hanni/enhance_documentation branch October 12, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:documentation documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete the documentation with doxygen comments for every existing feature until next release.
3 participants