-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning Cleanup #342
Warning Cleanup #342
Conversation
On the other side we have to get active from our side when a new version was released. If we stay with the our current system we will get it, if new checs were added, most of the time. |
True, but most of the new checks introduced (and most of the current checks in total) are guidelines for specific projects that we don't want. For example, making sure symbols are in the abseil/llvmlibc namespace. |
77b36e1
to
78e5665
Compare
86e65be
to
7bbbe80
Compare
This was causing a clang-tidy sign-conversion warning since the width and height fields are unsigned.
* Make class final * Mark destructor as override * Remove periods from log messages
cc52a49
to
7bd3245
Compare
This PR cleans up all of the current clang-tidy warnings to allow us to add a clang-tidy CI. There are a few other key changes in the PR such as switching our clang-tidy config style from enabling all checks, and then disabling ones we don't want to just enabling ones we want. This avoids the problem of new clang-tidy versions introducing new checks which we don't want.
Closes #341