Warning Cleanup #342
Merged
Warning Cleanup #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the other side we have to get active from our side when a new version was released. If we stay with the our current system we will get it, if new checs were added, most of the time. |
True, but most of the new checks introduced (and most of the current checks in total) are guidelines for specific projects that we don't want. For example, making sure symbols are in the abseil/llvmlibc namespace. |
yeetari
force-pushed
the
yeetari/warning-cleanup
branch
16 times, most recently
from
77b36e1
to
78e5665
Compare
yeetari
added
the
prio:blocker
yeetari
force-pushed
the
yeetari/warning-cleanup
branch
4 times, most recently
from
86e65be
to
7bbbe80
Compare
IAmNotHanni
reviewed
Apr 17, 2021
IAmNotHanni
reviewed
Apr 17, 2021
This was causing a clang-tidy sign-conversion warning since the width and height fields are unsigned.
* Make class final * Mark destructor as override * Remove periods from log messages
yeetari
force-pushed
the
yeetari/warning-cleanup
branch
from
cc52a49
to
7bd3245
Compare
IceflowRE
requested changes
May 3, 2021
IceflowRE
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up all of the current clang-tidy warnings to allow us to add a clang-tidy CI. There are a few other key changes in the PR such as switching our clang-tidy config style from enabling all checks, and then disabling ones we don't want to just enabling ones we want. This avoids the problem of new clang-tidy versions introducing new checks which we don't want.
Closes #341