Round Robin Queue Servicing #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…71_RoundRobinWorkStealing COM-471 Implement round robin stealing semantics.
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 94.2% 94.52% +0.31%
==========================================
Files 5 5
Lines 138 146 +8
==========================================
+ Hits 130 138 +8
Misses 8 8
Continue to review full report at Codecov.
|
yvoinov
added a commit
to yvoinov/thread-pool-cpp
that referenced
this pull request
Nov 16, 2018
Changes from inkooboo#24 are incorporated. Conditional variables instead spin-lock are kept as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a solution for #19. Servicing tasks in a round-robin fashion allows all workers to service all thread queues, but they prioritize their own. This protects us from the situation described in #19 without a significant performance impact.