Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io-classes version #50

Closed
wants to merge 4 commits into from
Closed

Bump io-classes version #50

wants to merge 4 commits into from

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented May 20, 2024

No description provided.

@bolt12 bolt12 requested a review from coot May 20, 2024 11:05
@bolt12 bolt12 self-assigned this May 20, 2024
Refactor to use `stToIO` and get rid of some redundant constraints.

It seems template haskell is generating some redundant constraints so I
disabled the warning.
@bolt12
Copy link
Contributor Author

bolt12 commented May 21, 2024

CHAP typed-protocols revision: IntersectMBO/cardano-haskell-packages#767

@bolt12 bolt12 enabled auto-merge May 21, 2024 09:51
@crocodile-dentist
Copy link

I've reviewed this and it looks good to me, but I guess @coot should have a final word.

@bolt12 bolt12 mentioned this pull request Jun 3, 2024
typed-protocols/typed-protocols.cabal Outdated Show resolved Hide resolved
@bolt12 bolt12 requested a review from coot June 3, 2024 09:29
Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it needs a rebase.

@coot
Copy link
Collaborator

coot commented Aug 29, 2024

Subsumed by #53, except for the formatting fixes.

@coot coot closed this Aug 29, 2024
auto-merge was automatically disabled August 29, 2024 12:39

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants