Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved README.md and added Examples #15

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Bibyutatsu
Copy link

Hi insilicomedicine,
I have tried updating the Readme file to include more detailed instructions on the installation and running of the model. I have also tried to give some explanation based on my understanding of the model and examples along with some examples of the output images.
Please consider this for the community as I have many colleagues and friends who had hard time running your amazing model.

In the future I am thinking of doing these:

  1. Updating the pretrain.ipynb with detailed explanations regarding the steps and significance of the numbers for the different variables.
  2. Trying to explain the train_vaelp() and train_rl() functions in detail.
  3. Add some explanation regarding how to change the gentrl tokenizer and encoder for custom datasets and tokens.

Thank you
I hope you consider my request

@danpol danpol requested review from danpol and binom16 October 25, 2019 12:37
Copy link
Contributor

@danpol danpol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, remove changes related to GENTRL pipeline image (both pdf and png), as they seem to be unchanged

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Bibyutatsu
Copy link
Author

Hi, I have made all the changes. Please review it.

@Bibyutatsu
Copy link
Author

Hi, Can you please review my changes and merge the pull request.

@gilnahmias
Copy link

Note a missing comma at setup.py, line 14 as per https://youtu.be/ya3AdrfKYzc?t=2470

Copy link
Author

@Bibyutatsu Bibyutatsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes incorporated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants