Merge pull request #171 from brendanjryan/bjr-single-warning

Only logs missing schema warning once

acceptance.bats

@@ -155,3 +155,11 @@
   run bin/kubeval fixtures/invalid.yaml --openshift
   [ "$status" -eq 1 ]
 }
+
+@test "Only prints a single warning when --ignore-missing-schemas is supplied" {
+  run bin/kubeval --ignore-missing-schemas fixtures/valid.yaml fixtures/valid.yaml
+  [ "$status" -eq 0 ]
+  [[ "${lines[0]}" == *"Warning: Set to ignore missing schemas"* ]]
+  [[ "${lines[1]}" == *"The file fixtures/valid.yaml contains a valid ReplicationController"* ]]
+  [[ "${lines[2]}" == *"The file fixtures/valid.yaml contains a valid ReplicationController"* ]]
+}

kubeval/kubeval.go

@@ -10,8 +10,6 @@ import (
 	"github.com/hashicorp/go-multierror"
 	"github.com/xeipuuv/gojsonschema"
 	"sigs.k8s.io/yaml"
-
-	"github.com/instrumenta/kubeval/log"
 )
 
 // ValidFormat is a type for quickly forcing
@@ -135,9 +133,6 @@ func validateResource(data []byte, schemaCache map[string]*gojsonschema.Schema,
 }
 
 func validateAgainstSchema(body interface{}, resource *ValidationResult, schemaCache map[string]*gojsonschema.Schema, config *Config) ([]gojsonschema.ResultError, error) {
-	if config.IgnoreMissingSchemas {
-		log.Warn("Warning: Set to ignore missing schemas")
-	}
 
 	schema, err := downloadSchema(resource, schemaCache, config)
 	if err != nil {

main.go

@@ -39,6 +39,9 @@ var RootCmd = &cobra.Command{
 	Long:    `Validate a Kubernetes YAML file against the relevant schema`,
 	Version: fmt.Sprintf("Version: %s\nCommit: %s\nDate: %s\n", version, commit, date),
 	Run: func(cmd *cobra.Command, args []string) {
+		if config.IgnoreMissingSchemas {
+			log.Warn("Warning: Set to ignore missing schemas")
+		}
 		success := true
 		windowsStdinIssue := false
 		outputManager := kubeval.GetOutputManager(config.OutputFormat)