Update to sigs.k8s.io/yaml #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the current YAML library from gopkg.in/yaml.v2 to sigs.k8s.io/yaml, a wrapper around the former. The k8s library provides better functionality with regards to unmarshaling a YAML file into a JSON-friendly data structure. This commit also includes various cleanups related to the change: * `convertToStringKeys` has been removed * functions `determineKind` and `determineAPIVersion` have been replaced by the more generic `getString` * functions `in`, `detectLineBreak` and `getString` have been moved to kubeval/utils.go Lastly, unit tests have been written for the new `getString` function
|
Thanks. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the current YAML library from gopkg.in/yaml.v2 to
sigs.k8s.io/yaml, a wrapper around the former. The k8s library provides
better functionality with regards to unmarshaling a YAML file into a
JSON-friendly data structure.
This commit also includes various cleanups related to the change:
convertToStringKeyshas been removeddetermineKindanddetermineAPIVersionhave been replacedby the more generic
getStringin,detectLineBreakandgetStringhave been moved tokubeval/utils.go
Lastly, unit tests have been written for the new
getStringfunction