Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect duplicate resources (same [API version, kind, namespace, name]) #180

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Sep 12, 2019

Introduces -n/--default-namespace to specify which namespace a resource would be assigned if none is explicitly defined in the manifest. Exhaustively tested.

@garethr
Copy link
Collaborator

garethr commented Apr 29, 2020

Thanks, useful suggestion. Would you be able to rebase this against the latest master and I'll get into the next release.

@AndiDog
Copy link
Contributor Author

AndiDog commented Apr 29, 2020

I rebased and successfully ran make test again

@garethr garethr merged commit 9b9f26f into instrumenta:master Apr 30, 2020
@m0un10
Copy link

m0un10 commented Mar 31, 2021

This just broke our pipeline when we upgraded to 0.16. Would you be open to a new PR which introduces --ignore-duplicate-resources Skip validation for duplication resources ?

Our use case is that we pipe a whole bunch of different test cases to kubeval to make sure our templating solution doesn't have a bug introduced regarding kubernetes semantics. Since we don't actually deploy our test manifests we don't care about duplicates and in fact we expect them as we have many different tests and some use the same names.

@carlossg
Copy link
Collaborator

sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants