Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the '--ignored-filename-patterns' flag. #192

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

bmcustodio
Copy link
Contributor

@bmcustodio bmcustodio commented Oct 21, 2019

This PR adds a -i/--ignored-filename-patterns flag which allows for specifying a list of filename patterns (regular expressions) to be ignored.

Signed-off-by: Bruno Miguel Custódio <[email protected]>
@chrisfowles
Copy link

anything holding up this PR?
this is really useful functionality when using kustomize to configmap generators with yaml config files

h3poteto added a commit to h3poteto/k8s-services that referenced this pull request Mar 30, 2020
diff --git a/.github/workflows/action.yaml b/.github/workflows/action.yaml
index 73ba176..a05e5f5 100644
--- a/.github/workflows/action.yaml
+++ b/.github/workflows/action.yaml
@@ -13,6 +13,6 @@ jobs:
           version: 1.14.7
           # instrumenta/kubeval#192
           # I'm waiting for ignore flag
-          files: external-prd/fascia,external-prd/grafana,external-prd/maintenance,external-prd/masudastream,external-prd/monitoring,external-prd/pleromaio,external-prd/seiyuwatch,external-prd/whalebirdsocial,configmap-aws-auth.yml,deploy-user-group.yml,ingress.yml,namespace.yml,rbac.yaml
+          files: external-prd
           token: ${{ secrets.GITHUB_TOKEN }}
           ignore_missing_schemas: true
h3poteto added a commit to h3poteto/k8s-services that referenced this pull request Mar 30, 2020
diff --git a/.github/workflows/action.yaml b/.github/workflows/action.yaml
index 5fed6d0..08e0bc1 100644
--- a/.github/workflows/action.yaml
+++ b/.github/workflows/action.yaml
@@ -13,7 +13,6 @@ jobs:
           version: 1.14.7
           # instrumenta/kubeval#192
           # I'm waiting for ignore flag
-          files: external-prd
+          files: external-prd/fascia
           token: ${{ secrets.GITHUB_TOKEN }}
           ignore_missing_schemas: true
-          skip_kinds: KMSSecret
h3poteto added a commit to h3poteto/k8s-services that referenced this pull request Mar 30, 2020
diff --git a/.github/workflows/action.yaml b/.github/workflows/action.yaml
index 08e0bc1..8277a37 100644
--- a/.github/workflows/action.yaml
+++ b/.github/workflows/action.yaml
@@ -13,6 +13,6 @@ jobs:
           version: 1.14.7
           # instrumenta/kubeval#192
           # I'm waiting for ignore flag
-          files: external-prd/fascia
+          files: external-prd/fascia,external-prd/grafana,external-prd/maintenance,external-prd/masudastream,external-prd/monitoring,external-prd/pleromaio,external-prd/seiyuwatch,external-prd/whalebirdsocial
           token: ${{ secrets.GITHUB_TOKEN }}
           ignore_missing_schemas: true
@garethr garethr merged commit de2a6df into instrumenta:master Apr 14, 2020
@garethr
Copy link
Collaborator

garethr commented Apr 14, 2020

Thanks, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants