Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ignored_filename_patterns to ignored_path_patterns #235

Merged
merged 2 commits into from
May 15, 2020

Conversation

adam-golab
Copy link
Contributor

This PR changes the -i/--ignored-filename-patterns flag to -i/--ignored-path-patterns. As it allows more advanced configuration which files should be ignored.
It works in a similar way like previously, so it accepts a list of directory patterns (regular expressions) to be ignored.
I've encountered difficulties with the previous solution when I wanted to configure the Github Actions for a repository used for GitOps approach. I wasn't able to run validation on all yaml files in any directory with exception of the .github directory.
Now it's possible with passing ignored_path_patterns="^\.github".

@garethr
Copy link
Collaborator

garethr commented May 15, 2020

Thanks for the submission. I think this is a useful idea, but it's also backwards compatible due to the change in the flag name. If you could add an alias for this for the old command name I'll be happy to merge.

@adam-golab
Copy link
Contributor Author

Sure @garethr
I've added and pushed the alias a moment ago. Hopefully, that's the correct way to do that

@garethr garethr merged commit dbeb2a2 into instrumenta:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants