-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tn/dcap rebased #1103
Tn/dcap rebased #1103
Conversation
- Only change is that dcap is not active (see main.rs) - Probably will not compile yet
# Conflicts: # enclave-runtime/src/initialization/initialization.rs # sidechain/consensus/aura/src/slot_proposer.rs
Distinguish between what generates the extrinsic and what generates the certificate
@@ -123,6 +123,7 @@ WORKDIR /usr/local/bin | |||
|
|||
COPY --from=builder /opt/sgxsdk/lib64 /opt/sgxsdk/lib64 | |||
COPY --from=builder /root/work/worker/bin/* ./ | |||
COPY --from=builder /lib/x86_64-linux-gnu /lib/x86_64-linux-gnu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copies some additional DCAP libraries, but also many libraries that we don't need. It makes our images quite a bit bigger.
Something I still want to understand and discuss with Felix. I created a follow up issue regarding this #1122
I think it is ready for a first review. @haerdib Maybe you also want to have a look of how I ruined your branch? 😰 😸 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I really appreciate how nice and clean this looks, such that I can even understand it without digging too deep into the code. I only have some minor comments.
- Fix comment - Format `Endlcave.edl`
- Add struct QveReport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool. From my point of view, this is ready to merge!
# Conflicts: # Cargo.lock # enclave-runtime/Cargo.lock # enclave-runtime/Enclave.edl
This is mostly a rebased version of #847. Please also check the comments there.
dcap
that switches to dcap from iasattestation-handler
which was introduced laterAttestationHandler
trait but decided against it (for now)