Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update squashfs VENDOR_PRODUCT #3605

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Replace squashfs-tools by squashfs-tools_project as squashfs-tools:squashfs-tools is not a valid CPE ID: https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Asquashfs-tools%3Asquashfs-tools

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10ddd3a) 78.66% compared to head (1de27c1) 78.42%.

❗ Current head 1de27c1 differs from pull request most recent head e0e54ec. Consider uploading reports for the commit e0e54ec to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3605      +/-   ##
==========================================
- Coverage   78.66%   78.42%   -0.25%     
==========================================
  Files         773      773              
  Lines       11641    11641              
  Branches     1362     1362              
==========================================
- Hits         9157     9129      -28     
- Misses       2048     2094      +46     
+ Partials      436      418      -18     
Flag Coverage Δ
win-longtests 78.42% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've opened up #3628 to maybe catch some of these when PRs are made but I wonder if we also need a script that checks all of them once a week or something.

@terriko terriko merged commit 6bc9c6f into intel:main Dec 19, 2023
21 checks passed
@ffontaine ffontaine deleted the fix-squashfs-checker branch December 19, 2023 06:48
inosmeet pushed a commit to inosmeet/cve-bin-tool that referenced this pull request Feb 16, 2024
Replace squashfs-tools by squashfs-tools_project as
squashfs-tools:squashfs-tools is not a valid CPE ID:
https://nvd.nist.gov/products/cpe/search/results?namingFormat=2.3&keyword=cpe%3A2.3%3Aa%3Asquashfs-tools%3Asquashfs-tools

Signed-off-by: Fabrice Fontaine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants