Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cra to vite migration: initial attempt #1078

Closed
wants to merge 4 commits into from
Closed

cra to vite migration: initial attempt #1078

wants to merge 4 commits into from

Conversation

ns212
Copy link
Contributor

@ns212 ns212 commented Mar 24, 2023

Attempt to migrate from CRA to vite.

Currently, npx vite build completes successfully in ca. 50 seconds. I have not confirmed whether the outputted application is actually functional.

TODO

  • Resolve duplicate src/utils/constants/colours.js - It was created to solve ESM import
  • Add missing devDependencies to package.json
  • Clean-up unnecessary config file
  • Confirm env var mapping working correctly for REACT_APP_. See envPrefix in vite.config.js

@ns212 ns212 requested a review from tomjeatt March 24, 2023 23:20
@vercel
Copy link

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
interbtc-ui-interlay ❌ Failed (Inspect) Mar 24, 2023 at 11:34PM (UTC)
interbtc-ui-interlay-testnet ❌ Failed (Inspect) Mar 24, 2023 at 11:34PM (UTC)
interbtc-ui-kintsugi ❌ Failed (Inspect) Mar 24, 2023 at 11:34PM (UTC)
interbtc-ui-kintsugi-hub ❌ Failed (Inspect) Mar 24, 2023 at 11:34PM (UTC)
interbtc-ui-kintsugi-testnet ❌ Failed (Inspect) Mar 24, 2023 at 11:34PM (UTC)

@github-actions
Copy link

Running Lighthouse audit...

@tomjeatt
Copy link
Collaborator

I'll close this for now as we won't be doing this work for a while—keep the branch open though, as I'd like to come back to it when we have time

@tomjeatt tomjeatt closed this Apr 20, 2023
@tomjeatt tomjeatt deleted the vite branch May 18, 2023 15:23
@tomjeatt tomjeatt restored the vite branch May 18, 2023 15:23
@tomjeatt tomjeatt deleted the vite branch January 4, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants