Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use-get-dex-volumes hook #1534

Merged
merged 3 commits into from
Aug 22, 2023
Merged

fix: use-get-dex-volumes hook #1534

merged 3 commits into from
Aug 22, 2023

Conversation

danielsimao
Copy link
Member

Interbtc UI Pull Request Template

Description

Add a brief description

Current behaviour (updates)

Please describe the current behaviour that you are modifying

New behaviour

Please describe the behaviour or changes this PR adds

Reproducible testing steps:

Please list all testing steps required for the reviewer to test this specific issue. Consider regressions and edge cases.

@vercel
Copy link

vercel bot commented Aug 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 10:22am
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 10:22am
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 10:22am
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 10:22am

@github-actions
Copy link

Running Lighthouse audit...

peterslany
peterslany suggested changes Aug 21, 2023
View reviewed changes
src/hooks/api/use-get-dex-volume.tsx Outdated Show resolved Hide resolved
peterslany
peterslany approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think explicit check of data.startVolumes.length === 0 would be easier to understand, but not a big deal, can go as is.

@danielsimao danielsimao merged commit 1084182 into master Aug 22, 2023
10 checks passed
@danielsimao danielsimao deleted the rui/fix-get-dex-volumes branch August 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterslany peterslany peterslany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielsimao @peterslany