Peter/fix dex volumes query #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
peterslany
force-pushed
the
peter/fix-dex-volumes-query
branch
from
a1a424c
to
e450000
Compare
danielsimao
approved these changes
Nov 22, 2023
tomjeatt
added a commit
that referenced
this pull request
Feb 5, 2024
* master: (221 commits) chore: release v2.41.5 chore: bump bridge (#1631) chore: release v2.41.4 api: rewrite python functions in javascript (#1630) chore: release v2.41.3 Switch Bifrost RPC node (#1627) chore: release v2.41.2 api: add dia fair price feed (#1619) chore: release v2.41.1 Tom/update parallel xcm nodes (#1621) Tom/hotfix/disable parallel xcm channel (#1620) chore: release v2.41.0 Feat: expose TVLs fetched via lib as part of api endpoints (#1605) [release] Interlay 2.40.2 (#1611) chore: release v2.40.2 update staking labels and format valuers (#1609) fix: add rewards alert and remove insights (#1607) fix: subwallet logo (#1606) Peter/fix dex volumes query (#1608) [release] Interlay 2.40.1 (#1603) ... # Conflicts: # package.json # yarn.lock
tomjeatt
added a commit
that referenced
this pull request
Feb 5, 2024
* master: (221 commits) chore: release v2.41.5 chore: bump bridge (#1631) chore: release v2.41.4 api: rewrite python functions in javascript (#1630) chore: release v2.41.3 Switch Bifrost RPC node (#1627) chore: release v2.41.2 api: add dia fair price feed (#1619) chore: release v2.41.1 Tom/update parallel xcm nodes (#1621) Tom/hotfix/disable parallel xcm channel (#1620) chore: release v2.41.0 Feat: expose TVLs fetched via lib as part of api endpoints (#1605) [release] Interlay 2.40.2 (#1611) chore: release v2.40.2 update staking labels and format valuers (#1609) fix: add rewards alert and remove insights (#1607) fix: subwallet logo (#1606) Peter/fix dex volumes query (#1608) [release] Interlay 2.40.1 (#1603) ... # Conflicts: # package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect query and calculation of pool volumes. Before this fix, volume of pools was calculated using total trading volume of 2 assets that are in the pool, which resulted in counting volume from other LPs in which the assets are pooled. Therefore, the displayed volume was incorrectly higher.
With this fix, trading volume is counted on per-pool basis. It has shortcoming of not being able to calculate volume for trades where more than one pool is utilized. To account for this edge case, squid data model would have to be refactored.