Fixed a small dashboard display issue #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
tomjeatt
approved these changes
Apr 5, 2024
|
I looked at the unit test failures with @mafux777 today and don't see a relation between the failure and the change he submitted. I'm guessing the unit test failures are a package dependency instead. |
|
Merged—thanks for fixing! You're right, there are no unit test failures related to this PR but I appreciate you checking. |
tomjeatt
added a commit
that referenced
this pull request
Jul 9, 2024
* master: (241 commits) chore: release v2.41.13 chore: bump bridge and add new dependency (#1664) Fixed a small dashboard display issue (#1658) chore: release v2.41.12 api: improve cache-control headers (#1659) chore: release v2.41.11 chore: release v2.41.10 HDX and BNC icons (#1655) api: add Vercel KV cache for storing market data (#1654) Tom/bridge 0.5.1 (#1651) chore: release v2.41.9 chore: bump bridge (#1648) chore: release v2.41.8 hotfix: XCM polkadot/kintsugi max transferable balance (#1645) Revert "[release] Interlay 2.41.7 (#1639)" (#1641) [release] Interlay 2.41.7 (#1639) chore: release v2.41.7 fix: chart counter enum and lower value for collateral (#1638) chore: release v2.41.6 refactor: line chart config (#1635) ... # Conflicts: # package.json # src/services/fetchers/cumulative-vault-collateral-volumes-fetcher.ts # yarn.lock
tomjeatt
added a commit
that referenced
this pull request
Jul 9, 2024
* master: (241 commits) chore: release v2.41.13 chore: bump bridge and add new dependency (#1664) Fixed a small dashboard display issue (#1658) chore: release v2.41.12 api: improve cache-control headers (#1659) chore: release v2.41.11 chore: release v2.41.10 HDX and BNC icons (#1655) api: add Vercel KV cache for storing market data (#1654) Tom/bridge 0.5.1 (#1651) chore: release v2.41.9 chore: bump bridge (#1648) chore: release v2.41.8 hotfix: XCM polkadot/kintsugi max transferable balance (#1645) Revert "[release] Interlay 2.41.7 (#1639)" (#1641) [release] Interlay 2.41.7 (#1639) chore: release v2.41.7 fix: chart counter enum and lower value for collateral (#1638) chore: release v2.41.6 refactor: line chart config (#1635) ... # Conflicts: # package.json # src/services/fetchers/cumulative-vault-collateral-volumes-fetcher.ts # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interbtc UI Pull Request Template
Description
Dashboard was crashing when certain data not available
To fix this, I added a question mark marking the variable as possibly undefined