Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OracleStatusCard by adding market pair on own line #245

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Improve OracleStatusCard by adding market pair on own line #245

merged 1 commit into from
Jul 1, 2022

Conversation

hitchhooker
Copy link

this commit fixes #244

@vercel
Copy link

vercel bot commented Apr 3, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

interbtc-ui-kintsugi – ./

🔍 Inspect: https://vercel.com/interlay/interbtc-ui-kintsugi/AqfYhmXgtXMfUWEhaHLHmgXsiUNB
✅ Preview: https://interbtc-ui-kintsugi-git-fork-kusamaxi-oraclefix-interlay.vercel.app

interbtc-ui-testnet – ./

🔍 Inspect: https://vercel.com/interlay/interbtc-ui-testnet/75y5XR6CZYZRCdH1nfhGVmGChUXX
✅ Preview: https://interbtc-ui-testnet-git-fork-kusamaxi-oraclefix-interlay.vercel.app

interbtc-ui-interlay – ./

🔍 Inspect: https://vercel.com/interlay/interbtc-ui-interlay/74RJoUqAwR9Z5fUuBkFGqAH7tf8n
✅ Preview: https://interbtc-ui-interlay-git-fork-kusamaxi-oraclefix-interlay.vercel.app

@github-actions
Copy link

github-actions bot commented Apr 3, 2022 •
edited
Loading

Running Lighthouse audit...

@hitchhooker hitchhooker changed the title fix btc / ksm price order Improve OracleStatusCard by adding market pair on own line Apr 9, 2022
@hitchhooker
Copy link
Author

image

tomjeatt
tomjeatt requested changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, looks good :) thanks for contributing. Couple of minor change requests.

src/components/Ring64/index.tsx Outdated Show resolved Hide resolved
src/components/Ring64/index.tsx Outdated Show resolved Hide resolved
src/components/Ring64/index.tsx Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Apr 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 11:48AM (UTC)
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 11:48AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 11:48AM (UTC)
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 11:48AM (UTC)
interbtc-ui-testnet ✅ Ready (Inspect) Visit Preview Jul 1, 2022 at 11:48AM (UTC)

@hitchhooker
Copy link
Author

replaced Ring64Pair component with Ring64Subtitle naming while changing heading2 into paragraph inside component.

tomjeatt
tomjeatt approved these changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) thank you for doing this, we love seeing the community getting involved.

src/components/Ring64/index.tsx Outdated Show resolved Hide resolved
src/components/Ring64/index.tsx Outdated Show resolved Hide resolved
@hitchhooker
Copy link
Author

seems like had forgot to add this commit. should be all fine now.

@hitchhooker hitchhooker mentioned this pull request May 4, 2022
Closed
@tomjeatt
Copy link
Collaborator

tomjeatt commented Jul 1, 2022

Note: reset and used --force push to fix the issue with unsigned commits which is why the commit history has gone

@tomjeatt tomjeatt merged commit 73efafc into interlay:master Jul 1, 2022
@tomjeatt tomjeatt deleted the oracle_fix branch July 1, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjeatt tomjeatt tomjeatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle pricing is upside down
2 participants
@hitchhooker @tomjeatt