refactor: remove api dependencies from UI components #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
tomjeatt
requested review from
crypto-engineer and
peterslany
and removed request for
peterslany,
crypto-engineer and
daniel-savu
|
I think the workflow issue is because we're also running it using |
peterslany
approved these changes
May 25, 2022
There was a problem hiding this comment.
Looks good :) Only issue I can see is that we are right now using two types CurrencySymbol and CurrencyIdLiteral which are same so the code is little inconsistent. Maybe we could unify it in the future and replace the lib types in other parts of the codebase with the new types defined in the UI codebase. Or are we going to use the newly-defined types only for the new component library built with the storybook?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Storybook is fixed, but there's an issue with the workflow pushing to Chromatic (which seems to be workflow related). No issue running Storybook locally, so PR unblocks UI development.
This PR removes all api dependencies from the new UI components (which resolves the Storybook issue) and creates configuration for vault collateral tokens. I'm happy with this solution for now - may be something we can improve upon as and when we make type changes in the lib.
Original comments:
This is still WIP, but before I tidy it up I'd really like some opinions on the solution.
The main thing here is to remove all
@interlay/interbtc-uitype dependencies from the components in thecomponentLibrarydirectory as the UI components shouldn't be using these types. (This also fixes the Storybook build).I've fixed this by created some additional types and utilities in the UI, but there may be better solutions - open to suggestions!