Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "Maximum Withdrawable Collateral" field and update the error message height #302

Merged

Conversation

crypto-engineer
Copy link
Contributor

@crypto-engineer crypto-engineer commented May 18, 2022

  • Maximum Withdrawable Collateral field is added against which the validation is run.
  • Fix a cosmetic issue related to displaying error messages.

Capture

@crypto-engineer crypto-engineer added the bug Something isn't working label May 18, 2022
@crypto-engineer crypto-engineer self-assigned this May 18, 2022
@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview May 25, 2022 at 0:15AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview May 25, 2022 at 0:15AM (UTC)
interbtc-ui-testnet ✅ Ready (Inspect) Visit Preview May 25, 2022 at 0:15AM (UTC)

@crypto-engineer crypto-engineer marked this pull request as draft May 18, 2022 09:50
@github-actions
Copy link

Running Lighthouse audit...

1 similar comment
@github-actions
Copy link

Running Lighthouse audit...

@crypto-engineer crypto-engineer marked this pull request as ready for review May 25, 2022 01:26
@crypto-engineer crypto-engineer changed the title fix: update the error message height fix: add "Maximum Withdrawable Collateral" field and update the error message height May 25, 2022
Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one minor comment

src/pages/Vaults/Vault/UpdateCollateralModal/index.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants