-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Peter/wallet integrations #304
Conversation
…allet-integrations
…e wallets & added option to disconnect account
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@peterslany Could you please resolve the conflict? |
Running Lighthouse audit... |
@peterslany |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterslany I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review and meaningful suggestions @crypto-engineer! I pushed an update. However I noticed that since you optimized the SVGs, the wallet icons are not scaling correctly, see:
I think some of the svg properties got removed from the assets with the optimization so maybe we are better off without optimizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey Peter, this shouldn't be happening :) we need to optimise the svg files, but optimisation shouldn't affect the rendering. Better to work out what the issue is and tweak if necessary, rather than leave the files unoptimised. |
Preview
When no supported wallet is installed:
When supported wallets are installed, user selects the one they wish to use:
After choosing the wallet, accounts from that wallet are displayed and user selects account they wish to connect with:
When account is connected,
Disconnect
button is shown -- this button allows user to disconnect account from dApp: