Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Peter/wallet integrations #304

Merged
merged 11 commits into from
May 27, 2022
Merged

Conversation

peterslany
Copy link
Contributor

  • Adding support for multiple wallets. Newly supported wallets are Talisman and SubWallet.
  • Account modal modified to allow selecting wallet and then displaying only accounts from selected wallet.
  • New disconnect feature that allows disconnecting the account from the dApp.

Preview

When no supported wallet is installed:

image

When supported wallets are installed, user selects the one they wish to use:

image

After choosing the wallet, accounts from that wallet are displayed and user selects account they wish to connect with:

image

When account is connected, Disconnect button is shown -- this button allows user to disconnect account from dApp:

image

@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview May 27, 2022 at 8:26AM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview May 27, 2022 at 8:26AM (UTC)
interbtc-ui-testnet ✅ Ready (Inspect) Visit Preview May 27, 2022 at 8:26AM (UTC)

@crypto-engineer
Copy link
Contributor

@peterslany Could you please resolve the conflict?

@github-actions
Copy link

Running Lighthouse audit...

@crypto-engineer
Copy link
Contributor

crypto-engineer commented May 26, 2022

@peterslany
SVG files should be optimized via https://jakearchibald.github.io/svgomg. Let me handle it on my side.

Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterslany I left some comments.

src/utils/constants/wallets.ts Outdated Show resolved Hide resolved
src/utils/constants/wallets.ts Outdated Show resolved Hide resolved
src/parts/AccountModal/index.tsx Outdated Show resolved Hide resolved
src/parts/AccountModal/index.tsx Outdated Show resolved Hide resolved
src/parts/AccountModal/index.tsx Outdated Show resolved Hide resolved
src/parts/AccountModal/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor Author

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review and meaningful suggestions @crypto-engineer! I pushed an update. However I noticed that since you optimized the SVGs, the wallet icons are not scaling correctly, see:
image

I think some of the svg properties got removed from the assets with the optimization so maybe we are better off without optimizing.

src/parts/AccountModal/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@crypto-engineer crypto-engineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomjeatt
Copy link
Collaborator

I think some of the svg properties got removed from the assets with the optimization so maybe we are better off without optimizing.

Hey Peter, this shouldn't be happening :) we need to optimise the svg files, but optimisation shouldn't affect the rendering. Better to work out what the issue is and tweak if necessary, rather than leave the files unoptimised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants