refactor: update collateral token to relay chain native token #318
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
|
Morning @crypto-engineer - this all sounds like it makes sense, but going to hold off approving until the KINT support PR is merged (not expecting any issues as that moves the vault collateral tokens to their own config, but don't want to risk any delay as that feature is already quite behind schedule!). |
There was a problem hiding this comment.
Looks good to me 👍 edit: just saw @tomjeatt's comment, so dismissed the review :)
peterslany
dismissed
their stale review
hold off from approving according to @tomjeatt's comment
Hi Peter, sorry could have been clearer :) no problem approving, just wanted to hold off merging! |
|
@tomjeatt |
crypto-engineer
force-pushed
the
refactor/relay-chain-token-vs-collateral-naming
branch
from
85df9dd
to
f6471fc
Compare
@crypto-engineer not yet, no - there are almost certainly going to be some conflicts, so we need to get the vault status card branch merged first, and then merge this in afterwards. Will keep you posted :) |
crypto-engineer
force-pushed
the
refactor/relay-chain-token-vs-collateral-naming
branch
from
f6471fc
to
f7c51bc
Compare
crypto-engineer
deleted the
refactor/relay-chain-token-vs-collateral-naming
branch
I found that we were referring to a relay chain's native tokens like DOT or KSM as collateral token. I think it's not correct. In the past, the relay chain's native token was the only collateral but now we are supporting multi-collaterals including KINT and USDC and more will be added. So I think we should update names accordingly.
This PR does not include any logical changes but just renaming. So I'd say it's safe to merge this PR without having a look at every single line of change in detail.