Peter/feat modal component #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Running Lighthouse audit... |
tomjeatt
requested changes
Jun 10, 2022
Hello @tomjeatt. Thanks for the thorough review :) I handled your comments, so feel free to re-review 👍 |
…eat-modal-component
tomjeatt
reviewed
Jun 14, 2022
tomjeatt
reviewed
Jun 14, 2022
peterslany
force-pushed
the
peter/feat-modal-component
branch
from
e430faa
to
cd7d36b
Compare
tomjeatt
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Modal component to the component library:
openprop passed to it istruemodal opens, when set tofalsemodal closesonClosecallback is called when there is click outside the modal, close button is clicked orEscapekey is pressedThis PR also adds Portal component and custom hook to delay unmounting of the component in order to animate the closing of the modal.