Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/transaction #326

Merged
merged 14 commits into from
Jun 9, 2022

Conversation

crypto-engineer
Copy link
Contributor

@crypto-engineer crypto-engineer commented Jun 7, 2022

The requested feature is to create a page where we can see the details of a transaction e.g. issue request, redeem request, replace request.

  • There's a page route like /transaction/:transactionType/:transactionHash where transactionType can be issue, redeem, & replace and transactionHash is a transaction hash. On that page, we display the necessary details of that transaction.
  • Navigation-wise, we can go to that page by clicking a request ID on an issue/redeem modal or a row of issue/redeem/replace tables. (This is under review of Jay and @alexbleau)

For this feature request @gregdhill made, I implemented routing and page structures in the first place.
Capture

@crypto-engineer crypto-engineer added the enhancement New feature or request label Jun 7, 2022
@crypto-engineer crypto-engineer self-assigned this Jun 7, 2022
@vercel
Copy link

vercel bot commented Jun 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview Jun 9, 2022 at 1:06PM (UTC)
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview Jun 9, 2022 at 1:06PM (UTC)
interbtc-ui-testnet ✅ Ready (Inspect) Visit Preview Jun 9, 2022 at 1:06PM (UTC)

@crypto-engineer crypto-engineer marked this pull request as draft June 7, 2022 19:51
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Running Lighthouse audit...

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Running Lighthouse audit...

Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a question about using the already existing path transactions for this PR instead of creating a new one.

src/pages/Transaction/index.tsx Show resolved Hide resolved
Copy link
Contributor

@peterslany peterslany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining the details behind implementation. Good to go! :)

@crypto-engineer crypto-engineer merged commit cdbcf66 into interlay:master Jun 9, 2022
@crypto-engineer crypto-engineer deleted the feature/transaction branch June 9, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants