-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/transaction #326
Feature/transaction #326
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Running Lighthouse audit... |
1 similar comment
Running Lighthouse audit... |
3613a8c
to
d96712a
Compare
src/pages/Dashboard/sub-pages/IssueRequests/IssueRequestsTable/index.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I have a question about using the already existing path transactions
for this PR instead of creating a new one.
c41fb67
to
1b644d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explaining the details behind implementation. Good to go! :)
The requested feature is to create a page where we can see the details of a transaction e.g. issue request, redeem request, replace request.
/transaction/:transactionType/:transactionHash
wheretransactionType
can beissue
,redeem
, &replace
andtransactionHash
is a transaction hash. On that page, we display the necessary details of that transaction.For this feature request @gregdhill made, I implemented routing and page structures in the first place.