chore: use absolute imports with @ alias and format code on save #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
peterslany
commented
Jun 10, 2022
tomjeatt
approved these changes
Jun 10, 2022
There was a problem hiding this comment.
hi @peterslany - config looks good, but I'm not going to review 233 files so I'll take your word that it all works :)
|
Running Lighthouse audit... |
…hore-vscode-onsaveactions
peterslany
force-pushed
the
peter/chore-vscode-onsaveactions
branch
from
64726fe
to
6d88f93
Compare
Yes, I tested it and it worked, also updated storybook config, so Chromatic works as it should too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new format of absolute path imports: using
@/alias forsrc/. PR is big because all imports are converted into this new format.Also VS Code on-save actions are defined which make the prettier and ESLint fixing run on each save of the file.
Requirements to be able to utilize auto-formatting on each save are 2 VS Code extensions:
prettier-vscodevscode-eslint